Skip to content

Fix datanode stuck when meets disk error#11486

Merged
xingtanzjr merged 1 commit intomasterfrom
fix_start_fail_stuck
Nov 8, 2023
Merged

Fix datanode stuck when meets disk error#11486
xingtanzjr merged 1 commit intomasterfrom
fix_start_fail_stuck

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented Nov 7, 2023 •
edited
Loading

Description

#11172 was trying to fix datanode stuck issue when meets disk error. However, there are still some problems need to fix.

  1. When DataRegion compaction recover failed, the CountDownLatch of WALRecoverManager needs to countdown as well.
  2. The waitForResult method of AbstractResultListener may have the endless loop, when catches an InterruptedException. We need to add a break logic to exit the loop.
  3. After calling the stop method in DataNode, some threads may still live. Therefore, adding a System.exit is a better way to exit the DataNode.

How to test

See #11172

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #11486 (cb72a08) into master (3244255) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #11486      +/-   ##
============================================
- Coverage     49.03%   49.01%   -0.02%     
+ Complexity    24601    24590      -11     
============================================
  Files          2772     2772              
  Lines        173030   173036       +6     
  Branches      20764    20764              
============================================
- Hits          84837    84808      -29     
- Misses        88193    88228      +35
Files Coverage Δ
...ain/java/org/apache/iotdb/db/service/DataNode.java 5.07% <0.00%> (-0.02%) ⬇️
...ion/wal/utils/listener/AbstractResultListener.java 80.00% <0.00%> (-5.72%) ⬇️
.../iotdb/db/storageengine/dataregion/DataRegion.java 50.51% <0.00%> (-0.11%) ⬇️

... and 14 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@xingtanzjr xingtanzjr merged commit b478d96 into master Nov 8, 2023
HTHou added a commit that referenced this pull request Dec 20, 2023
@HTHou
Fix datanode stuck when meets disk error (#11486)
e3d814e
@HTHou HTHou deleted the fix_start_fail_stuck branch December 26, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HTHou @codecov-commenter @xingtanzjr